Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dxcopt: Support full container and restore extra data to module #4845

Merged
merged 30 commits into from
Dec 13, 2022
Merged

dxcopt: Support full container and restore extra data to module #4845

merged 30 commits into from
Dec 13, 2022

Commits on Dec 3, 2022

  1. dxcopt: Support full container and restore subobjects/root sig to module 

    This modifies IDxcOptimizer::RunOptimizier to accept full DxilContainer input.
When full container input is used, this also restores subobjects from RDAT or root signature data from RST0 to the DxilModule state.
Serialization of these to metadata in module bitcode output still requires hlsl-dxilemit step.
    @tex3d
    tex3d committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    298aca7 View commit details
    Browse the repository at this point in the history

  2. Move more code into the try block.

    @tex3d
    tex3d committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    9956bac View commit details
    Browse the repository at this point in the history

  3. Beginning outline of tests

    @tex3d
    tex3d committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    dea301d View commit details
    Browse the repository at this point in the history

  4. Better return code when container doesn't contain DXIL

    @tex3d
    tex3d committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    dd5b6bd View commit details
    Browse the repository at this point in the history

  5. Assemble to container, add a test

    @jeffnn
    jeffnn committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    f91f943 View commit details
    Browse the repository at this point in the history

  6. More test

    @jeffnn
    jeffnn committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    5f72f78 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. Fix ubuntu build?

    @jeffnn
    jeffnn committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    7c13794 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. Assemble to container outside optimizer

    @jeffnn
    jeffnn committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    b91c86f View commit details
    Browse the repository at this point in the history

  2. Copy PSV0 ViewID data back to DxilModule serialized data 

    Small refactor to separate code that translates between ViewID data format serialized in DxilModule and the PSV0 data format.
Added the equivalent functions to go back to DxilModule serialized version from PSV0 used in IDxcOptimizer.
    @tex3d
    tex3d committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    b4504f5 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Restore resource names from shader reflection part (STAT)

    @tex3d
    tex3d committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    99abb03 View commit details
    Browse the repository at this point in the history

  2. Restore Resource HLSL types and type annotations 

    Also, make sources const.
    @tex3d
    tex3d committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    ff66248 View commit details
    Browse the repository at this point in the history

  3. Some error checking when copying resource info

    @tex3d
    tex3d committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    ecc4330 View commit details
    Browse the repository at this point in the history

  4. Remove existing type annotation if present, to force replacement

    @tex3d
    tex3d committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    2a4e96f View commit details
    Browse the repository at this point in the history

  5. Start of view id tests

    @jeffnn
    jeffnn committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    e2adc94 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'dxcopt-from-container' of github.com:tex3d/DirectXShade… 

    …rCompiler into dxcopt-from-container
    @jeffnn
    jeffnn committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    5886db8 View commit details
    Browse the repository at this point in the history

  7. Test by comparing before and after

    @jeffnn
    jeffnn committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    97beb9c View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. View instancing tests

    @jeffnn
    jeffnn committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    92c66af View commit details
    Browse the repository at this point in the history

  2. GS test

    @jeffnn
    jeffnn committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    8c22fb4 View commit details
    Browse the repository at this point in the history

  3. Move function restoring resource reflection to DxilModule 

    - Minor change to remove unnecessary code checking for existing type annotation in target module and deleting it.
- Restore the name of the global variable if one is attached to the resource entry.
- Renamed the function to RestoreResourceReflection for clarity.
    @tex3d
    tex3d committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    f1900dd View commit details
    Browse the repository at this point in the history

  4. Check target GlobalSymbol() before trying to set the name

    @tex3d
    tex3d committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    e3c7d67 View commit details
    Browse the repository at this point in the history

  5. Resource copy tests

    @jeffnn
    jeffnn committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    4ca6522 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'dxcopt-from-container' of github.com:tex3d/DirectXShade… 

    …rCompiler into dxcopt-from-container
    @jeffnn
    jeffnn committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    c31ab03 View commit details
    Browse the repository at this point in the history

  7. Not should be not-not, initialize from the right data

    @jeffnn
    jeffnn committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    70ac5fd View commit details
    Browse the repository at this point in the history

  8. ARE_EQUAL_STR

    @jeffnn
    jeffnn committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    d07d3a2 View commit details
    Browse the repository at this point in the history

  9. Test fixes

    @jeffnn
    jeffnn committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    a3733c9 View commit details
    Browse the repository at this point in the history

  10. test fixes

    @jeffnn
    jeffnn committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    89ddbb7 View commit details
    Browse the repository at this point in the history

  11. Undo mistaken checkin

    @jeffnn
    jeffnn committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    e823397 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2022

  1. Tests for i/o dependency map

    @jeffnn
    jeffnn committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    190f138 View commit details
    Browse the repository at this point in the history

  2. Test all tables

    @jeffnn
    jeffnn committed Dec 10, 2022
    Configuration menu
    Copy the full SHA
    0182587 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. NC: Update comment for what's restored from STAT

    @tex3d
    tex3d committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    1cfd5e7 View commit details
    Browse the repository at this point in the history