[SPIRV] Generate OpSource for All Includes #6094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-perron
approved these changes
Jan 15, 2024
sudonatalie
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation generates SPIR-V OpSource instructions from within EmitVisitor::emitDebugLine(), part of OpLine processing, improperly tying the two together. Only files including instructions that generate an OpLine will generate an OpSource, meaning that many include files are missed. An included file may include nothing more than preprocessor macro definitions, but that should still generate an OpSource.
The SourceManager already tracks the correct and complete list of files generated by the preprocessor in LineTable. We therefore propose a new pair of SourceManager api's that expose the LineTable. SpirvEmitter::HandleTranslationUnit() may now simply and directly create all required OpSource instructions.