Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sema] Check FunctionDecl has identifier before getName. (#6439) #6457

Merged

Conversation

python3kgae
Copy link
Contributor

Use identifier name without check the identifier exists will cause crash.

Fixes #6426


Co-authored-by: Tex Riddell texr@microsoft.com
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 7581ff4)

)

Use identifier name without check the identifier exists will cause
crash.

Fixes microsoft#6426

---------

Co-authored-by: Tex Riddell <texr@microsoft.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 7581ff4)
@python3kgae python3kgae requested a review from a team as a code owner March 25, 2024 21:15
Copy link
Member

@pow2clk pow2clk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@python3kgae python3kgae merged commit 11e1318 into microsoft:release-1.8.2403 Mar 26, 2024
13 checks passed
@python3kgae python3kgae deleted the merge_identifier_exist branch March 26, 2024 01:27
pow2clk pushed a commit to pow2clk/DirectXShaderCompiler that referenced this pull request Jul 15, 2024
) (microsoft#6457)

Use identifier name without check the identifier exists will cause
crash.

Fixes microsoft#6426

---------

Co-authored-by: Tex Riddell <texr@microsoft.com>
Co-authored-by: github-actions[bot]
<github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 7581ff4)
(cherry picked from commit 11e1318)
pow2clk added a commit that referenced this pull request Jul 16, 2024
Merges the following changes into mesh nodes to fix a known bug that
required a point release in the march release branch and also some build
fixes for new visual studio diagnostics.

9ca52f4 Add duplicate pragma (#6732)
7809c0b Remove Windows C++ redist hack (#6692)
33277a1 Workaround broken GitHub runner images (#6683)
1b9a796 [Sema] Check FunctionDecl has identifier before getName.
(#6439) (#6457)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants