Update directx headers to facilitate future updates #6856
+119
−345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…void conflicts and allow the latest DirectX-Headers to be used rather than a 2 year outdated one. Unified lots of types; all fixed int types now align properly between windows and unix (more importantly; between the two winadapters). Removed duplicate defines and type definitions. Replaced CROSS_PLATFORM_UUIDOF with __CRT_UUID_DECL so that it can use the uuid macro from wsl. Fixed type incompatiblity of a LPBOOL which really refered to a bool* (BOOL is 32-bit according to WSL).
…nition that DirectX-Headers uses to define GUIDs so that either implementation of __uuidof can find the GUID.
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Nielsbishere
changed the title
…e. Also don't like an include named winadapter.h in a file named WinAdapter.h
…rt. Added CLSID_D3D12SDKConfiguration for older Windows sdks
Nielsbishere
changed the title
…uff that relies on that
…iler into update_directx_headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some things on unix to allow further updates from DirectX-Headers.
Important fixes to ensure #6827 this will be able to build, it's a lot cleaner than the fixes there and I will be porting them over later. The major changes;
Important note; needs the corresponding DirectX-Headers update that prepared a little bit for it (microsoft/DirectX-Headers#137). After that merge, please change the submodule from Oxsomi/DirectX-Headers back to Microsoft/DirectX-Headers.