Replace reachable llvm_unreachable with errors in HLSignatureLower #6888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constrain IA signature allocation to legal bounds.
python3kgae
reviewed
Sep 3, 2024
| @@ -73,8 +73,10 @@ unsigned PackDxilSignature(DxilSignature &sig, DXIL::PackingStrategy packing) { | |||
| // incrementally assign each element that belongs in the signature to the | |||
| // start of the next free row | |||
| for (auto &SE : packElements) { | |||
| SE.SetLocation(rowsUsed, 0); | |||
| rowsUsed += SE.GetRows(); | |||
| if (SE.GetRows() <= (32 - rowsUsed)) { | |||
There was a problem hiding this comment.
Should we report error when out of bound?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, constrain IA signature allocation to legal bounds.