Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SV_DispatchGrid semantic in a nested record #6931

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tcorringham
Copy link
Collaborator

The SV_DispatchGrid DXIL metadata for a node input record was not generated in cases where:

  • the field with the SV_DispatchGrid semantic was in a nested record
  • the field with the SV_DispatchGrid semantic was in a record field
  • the field with the SV_DispatchGrid semantic was inherited from a base record
  • in any combinations of the above

Added FindDispatchGridSemantic() to be used by the AddHLSLNodeRecordTypeInfo() function, and added a test case.

Fixes #6928

The SV_DispatchGrid DXIL metadata for a node input record was not generated
in cases where:
- the field with the SV_DispatchGrid semantic was in a nested record
- the field with the SV_DispatchGrid semantic was in a record field
- the field with the SV_DispatchGrid semantic was inherited from a base record
- in any combinations of the above

Added FindDispatchGridSemantic() to be used by the AddHLSLNodeRecordTypeInfo()
function, and added a test case.

Fixes microsoft#6928
@tcorringham tcorringham self-assigned this Sep 24, 2024
@tcorringham tcorringham requested a review from a team as a code owner September 24, 2024 15:31
@damyanp damyanp assigned tex3d and unassigned tcorringham Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Status: Triaged
Development

Successfully merging this pull request may close these issues.

SV_DispatchGrid semantic in a nested record
2 participants