Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C#] FasterLogIterator.CompleteUntilRecordAt() should not verify checksum of the record, even if checksumming is enabled #601

Closed
mito-csod opened this issue Nov 23, 2021 · 1 comment
Closed

[C#] FasterLogIterator.CompleteUntilRecordAt() should not verify checksum of the record, even if checksumming is enabled #601

mito-csod opened this issue Nov 23, 2021 · 1 comment

Comments

@mito-csod
Copy link
Contributor

CompleteUntilRecordAt() currently fails occasionally due to checksum failures. This is because the AsyncGetHeaderOnlyFromDiskCallback method reads only enough data in to capture the header. The solution is to never verify checksum in GetRecordLengthAndFree()--this should be "safe" since this method is not used to retrieve records themselves.
@mito-csod mito-csod changed the title [C#] FassterLogIterator.CompleteUntilRecordAt() should not verify checksum of the record, even if checksumming is enabled [C#] FasterLogIterator.CompleteUntilRecordAt() should not verify checksum of the record, even if checksumming is enabled Nov 23, 2021
mito-csod added a commit to mito-csod/FASTER that referenced this issue Nov 23, 2021
@mito-csod
disable checksum verification in FasterLogIterator.CompleteUntilRecor…
5df7c7d 
…dAt() [microsoft#601]
@mito-csod mito-csod mentioned this issue Nov 23, 2021
Merged
badrishc added a commit that referenced this issue Nov 23, 2021
@mito-csod @badrishc
Disable checksum verification in FasterLogIterator.CompleteUntilRecor…
fccfbcf 
…dAt() (#602)

* MemoryPool-based override for FasterLog.ReadAsync()

* FasterLogIterator.CompleteUntilRecordAtAsync() added.

* disable checksum verification in FasterLogIterator.CompleteUntilRecordAt() [#601]

Co-authored-by: Badrish Chandramouli <badrishc@microsoft.com>
@badrishc
Copy link
Contributor

Makes sense, merged PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@badrishc @mito-csod