Prepopulate log file handles #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ASA's reference data workflow, we must create new FASTER instances and thus new devices regularly. We also must prepopulate log file handles to satisfy some requirements for our multi-tentant service. Currently, we create a new LocalStorageDevice, then add each file handle with GetOrAddHandle, which inserts to a ConcurrentDictionary, and when the count of these files reach the thousands, this prepopulation can take upwards of 10s of seconds. This change allows us to prepopulate the ConcurrentDictionary with a flat array, eliminating this latency.