-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C#] Extension to allow Read of all versions of key in FasterKV log #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TedHartMS
commented
Oct 6, 2020
•
edited
Loading
edited
- Add IAdvancedFunctions, which adds parameters to IFunctions methods:
- ReadCompletionCallback has an additional RecordInfo parameter
- Reader/Writer methods have a logicalAddress parameter
- Add AdvancedClientSession, which is a parallel (not inheriting) class to ClientSession that takes an IAdvancedFunctions instance
- Add AdvancedFunctionsBase and AdvancedSimpleFunctions
- Add a DEBUG-only IClientSession interface to ensure the Session classes are consistent
- Add overloads of Read() and ReadAsync() that take a starting address that is used instead of a hash table lookup (traceback for key match is still done), and returns a copy of a found record's RecordInfo whose PreviousAddress can be passed to the next iteration of Read() to trace back a key's records. This requires IAdvancedFunctions and AdvancedClientSession
- Add ReadAtAddress and ReadAtAddressAsync to read from an address when there is no key available (the key is passed to the IFunctions or IAdvancedFunctions Read methods)
badrishc
reviewed
Oct 8, 2020
badrishc
changed the title
Read address
[C#] Extension to allow Read of all versions of key in FasterKV log
Oct 9, 2020
TedHartMS
force-pushed
the
ReadAddress
branch
from
October 11, 2020 04:19
df41781
to
6ce0af0
Compare
…have the new form call the old one so existing implementations continue to work
…d.cs were already there)
- Make FasterKV methods taking Functions type parameter internal; FasterKV.For(f) should be used instead, to get IFunctions vs. IAdvancedFunctions overloading - Remove parameterless FasterKV.For<>()
…rdInfo) operations DEBUG-only
…o FasterKV; add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.