Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] Extension to allow Read of all versions of key in FasterKV log #347

Merged
merged 34 commits into from
Dec 1, 2020

Conversation

TedHartMS
Copy link
Contributor

@TedHartMS TedHartMS commented Oct 6, 2020

  • Add IAdvancedFunctions, which adds parameters to IFunctions methods:
    • ReadCompletionCallback has an additional RecordInfo parameter
    • Reader/Writer methods have a logicalAddress parameter
  • Add AdvancedClientSession, which is a parallel (not inheriting) class to ClientSession that takes an IAdvancedFunctions instance
  • Add AdvancedFunctionsBase and AdvancedSimpleFunctions
  • Add a DEBUG-only IClientSession interface to ensure the Session classes are consistent
  • Add overloads of Read() and ReadAsync() that take a starting address that is used instead of a hash table lookup (traceback for key match is still done), and returns a copy of a found record's RecordInfo whose PreviousAddress can be passed to the next iteration of Read() to trace back a key's records. This requires IAdvancedFunctions and AdvancedClientSession
  • Add ReadAtAddress and ReadAtAddressAsync to read from an address when there is no key available (the key is passed to the IFunctions or IAdvancedFunctions Read methods)

@badrishc badrishc changed the title Read address [C#] Extension to allow Read of all versions of key in FasterKV log Oct 9, 2020
TedHartMS and others added 22 commits October 11, 2020 10:46
…have the new form call the old one so existing implementations continue to work
- Make FasterKV methods taking Functions type parameter internal; FasterKV.For(f) should be used instead, to get IFunctions vs. IAdvancedFunctions overloading
- Remove parameterless FasterKV.For<>()
@badrishc badrishc merged commit 5281504 into master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants