[C++] Remote Device for FasterKv #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chinkulkarni
commented
Oct 16, 2020
chinkulkarni
commented
- Adds in a new device called StorageDevice that can transparently flush local files to a remote tier
- Reads are serviced from the appropriate tier
- Compiles and unit tests on Linux
- Unit tests and flags are compiled only when a flag is passed in to CMake
- A helper script helps install dependencies on Linux
* Device compiles on Windows * Tests against emulator * Added to CI
Try integrating installed dependencies with msbuild using vcpkg
If FASTER's page size and the remote tiers max write size don't match, then break down IOs appropriately.
badrishc
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.