[C#] Clean up TargetFramework defines, enable IAsyncEnumerable on netstandard2.0/net461 #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TedHartMS
commented
Nov 25, 2020
•
TedHartMS
commented
- Change the order in the csproj so netstandard2.1 is first, which appears to be the one that's used by the IDE for #if resolution
- Switch to the TargetFramework preprocessor symbols already defined by the build system (we use NETSTANDARD and NETSTANDARD2_1)
- Add Microsoft.Bcl.AsyncInterfaces for pre-netstandard2.1 frameworks, which allows IAsyncEnumerable to work
- Added tests for FasterLogIterator.GetAsyncEnumerable()
- Add netcore2.1 in FASTER.tests.csproj
- Add task to run tests in C# Linux pipeline
- Change the order in the csproj so netstandard2.1 is first, which appears to be the one that's used by the IDE for #if <TargetFramework> resolution - Switch to the TargetFramework preprocessor symbols already defined by the build system (we use NETSTANDARD and NETSTANDARD2_1) - Add Microsoft.Bcl.AsyncInterfaces for pre-netstandard2.1 frameworks, which allows IAsyncEnumerable to work - Added tests for FasterLogIterator.GetAsyncEnumerable() - Enable netcore2.2 in FASTER.tests.csproj
…sterLogIterator.GetAsyncEnumerable(MemoryPool<T>)
Put UseDotNet@2 task in the right place
…on the pipeline by default)
…sterLogResumeTests
…SectorSize behavior
badrishc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.