make FasterLogScanIterator read behavior consistent in the face of iterator disposal #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing two flows:
1.
a. caller initiates GetNext
b. Log gets disposed (to be deleted)
2.
a. Log gets disposed
b. at the same time, a GetNext is initiated
In flow 1 today, we get a return-value of false from GetNext, whereas
In flow 2 today, we get an ObjectDisposedException.
badrishc
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make FasterLogScanIterator read behavior consistent across the following two flows:
a. caller initiates GetNext
b. Log gets disposed
a. Log gets disposed
b. a GetNext is initiated
In flow 1 today, we get a return-value of false from GetNext, whereas
In flow 2 today, we get an ObjectDisposedException.