-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C#] Quite a few new tests to make FasterLog and FasterKV functionally covered #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y passing in CancellationToken
* Add IAdvancedFunctions documentation * Fix links
…rameter combinations
* First pass on RecoverAsync * Change to semaphore * FIx stale tokens; make test names consistent * add readonly * Add CancellationToken to RecoverAsync; increase CancellationToken usage in a couple other places * Add clarifying comments and expected behavior in FasterLogPubSub. Add FasterLog.CreateAsync (which calls RecoverAsync) and RecoverReadOnlyAsync. Replace obsolete DeleteDirectory functions with Directory.Delete(path, true) * Remove some debugging code * FasterLogPubSub: catch OperationCanceledException, add using/Dispose()
…se tests passing before checking them.
…were not already covered by other tests
…ries in log file to help reduce the execution time for entire test run
…ced ReadAtAddress
…t in master yet, so need this to not break the test queueu
* Fixed GrowIndex to work correctly, and return only after index size doubling is complete. * Reset overflowBucketsAllocator during resize. * Add API to get number of overflow buckets.
* Add RecordInfo.SpinLock * Pass kInvalidAddress to SingleReader for readcache * IntExclusiveLocker does not require unsafe * Assert logicalAddress >= ReadOnlyAddress in RecordAccessor.SpinLock Co-authored-by: Badrish Chandramouli <badrishc@microsoft.com>
* Initial sample + minor mods to support use case * cleanup * added zipf distribution to example. moved to samples folder. * updates * Change CopyReadsToTail from bool to enum. * Add support for CopyReadsToTail to copy to tail when read from ReadOnly region. * updated sample, use container to store value being reinserted. * Added support for SubscribeEvictions * updated sample to ignore tombstones
…fixed-size part) on the main log. (#399)
Co-authored-by: Stephan Kempkes <stephan.kempkes@esrlabs.com>
…sts. Will put them back when it gets fixed.
badrishc
approved these changes
Mar 7, 2021
Amazing work, thanks Darren! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These test were put in place to increase functional coverage of the Faster Log and Faster KV features.