Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] Fixing warnings #615

Merged
merged 5 commits into from
Dec 12, 2021
Merged

[C#] Fixing warnings #615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2f47ee9
Fixing warnings.
badrishc Dec 12, 2021
6dfbc31
undo unrelated change
badrishc Dec 12, 2021
9e9697e
fix
badrishc Dec 12, 2021
be02420
fix2
badrishc Dec 12, 2021
1a7519e
nit
badrishc Dec 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions azure-pipelines-full.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:

- job: 'cppWindows'
pool:
vmImage: vs2017-win2016
vmImage: windows-latest
displayName: 'C++ (Windows)'

strategy:
Expand All @@ -77,10 +77,10 @@ jobs:

steps:
- task: CMake@1
displayName: 'CMake .. -G"Visual Studio 15 2017 Win64"'
displayName: 'CMake .. -G"Visual Studio 16 2019"'
inputs:
workingDirectory: 'cc/build'
cmakeArgs: '.. -G"Visual Studio 15 2017 Win64"'
cmakeArgs: '.. -G"Visual Studio 16 2019"'

- task: MSBuild@1
displayName: 'Build solution cc/build/FASTER.sln'
Expand Down Expand Up @@ -157,7 +157,7 @@ jobs:

# - job: 'cppBlobsWindows'
# pool:
# vmImage: vs2017-win2016
# vmImage: windows-latest
# displayName: 'C++ Blobs (Windows)'

# strategy:
Expand All @@ -172,10 +172,10 @@ jobs:

# steps:
# - task: CMake@1
# displayName: 'CMake .. -G"Visual Studio 15 2017 Win64" -DUSE_BLOBS=ON'
# displayName: 'CMake .. -G"Visual Studio 16 2019" -DUSE_BLOBS=ON'
# inputs:
# workingDirectory: 'cc/build'
# cmakeArgs: '.. -G"Visual Studio 15 2017 Win64" -DUSE_BLOBS=ON'
# cmakeArgs: '.. -G"Visual Studio 16 2019" -DUSE_BLOBS=ON'

# - script: 'git clone https://github.com/microsoft/vcpkg'
# workingDirectory: 'cc/build'
Expand Down
12 changes: 6 additions & 6 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:

- job: 'cppWindows'
pool:
vmImage: vs2017-win2016
vmImage: windows-latest
displayName: 'C++ (Windows)'

strategy:
Expand All @@ -77,10 +77,10 @@ jobs:

steps:
- task: CMake@1
displayName: 'CMake .. -G"Visual Studio 15 2017 Win64"'
displayName: 'CMake .. -G"Visual Studio 16 2019"'
inputs:
workingDirectory: 'cc/build'
cmakeArgs: '.. -G"Visual Studio 15 2017 Win64"'
cmakeArgs: '.. -G"Visual Studio 16 2019"'

- task: MSBuild@1
displayName: 'Build solution cc/build/FASTER.sln'
Expand Down Expand Up @@ -163,7 +163,7 @@ jobs:

# - job: 'cppBlobsWindows'
# pool:
# vmImage: vs2017-win2016
# vmImage: windows-latest
# displayName: 'C++ Blobs (Windows)'

# strategy:
Expand All @@ -178,10 +178,10 @@ jobs:

# steps:
# - task: CMake@1
# displayName: 'CMake .. -G"Visual Studio 15 2017 Win64" -DUSE_BLOBS=ON'
# displayName: 'CMake .. -G"Visual Studio 16 2019" -DUSE_BLOBS=ON'
# inputs:
# workingDirectory: 'cc/build'
# cmakeArgs: '.. -G"Visual Studio 15 2017 Win64" -DUSE_BLOBS=ON'
# cmakeArgs: '.. -G"Visual Studio 16 2019" -DUSE_BLOBS=ON'

# - script: 'git clone https://github.com/microsoft/vcpkg'
# workingDirectory: 'cc/build'
Expand Down
4 changes: 2 additions & 2 deletions cc/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ if (MSVC)
set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} /Od /RTC1 /MDd")
set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} /O2 /Oi /Gy- /MD")

set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /DEBUG /OPT:REF /OPT:NOICF /INCREMENTAL:NO")
set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /DEBUG /OPT:REF /OPT:NOICF /INCREMENTAL:NO")
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /DEBUG /OPT:NOICF")
set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /DEBUG /OPT:NOICF")
else()
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++14")

Expand Down
4 changes: 2 additions & 2 deletions cs/test/TestUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,13 @@ public enum DeviceType
bool preallocateFile = false;
long capacity = -1; // Capacity unspecified
bool recoverDevice = false;
bool useIoCompletionPort = false;
bool disableFileBuffering = true;

switch (testDeviceType)
{
#if WINDOWS
case DeviceType.LSD:
bool useIoCompletionPort = false;
bool disableFileBuffering = true;
#if NETSTANDARD || NET
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) // avoids CA1416 // Validate platform compatibility
#endif
Expand Down