-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An agent implementation of MathChat #1076
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A significant amount of effort is devoted to handling the python code which seems to be suitable for executing in a Jupyter Notebook environment. Maybe it'll be cleaner to consider implementing an executor based on ipykernel in future.
The current implementation is better than before. To keep this agent in the core library, the following is required:
- test code and code coverage
- be aware of the maintenance requirement. For example, if we make changes to UserProxyAgent, it may break the MathUserProxyAgent. It could happen that we'll need to temporarily disable it until you make it functional again. You'll also be required to review PRs more timely.
The benefit of including it in the core library is to keep it up-to-date and gets improvement over time (including contributions from follow-up research), until it gets actual usage and makes real impact. The associated cost will be the maintenance effort. Please take these into account and decide whether you'd like to keep it in or out of the core library.
typo in the name of the notebook: "autogent_agent_MathChat.ipynb" should be "autogen_agent_MathChat.ipynb" |
We can disable macos py3.7 test per #1079 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ready to run the OpenAI test?
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Why are these changes needed?
Implement MathChat using the agent framework.
Related issue number
See tasks in #1066. The blog post about MathChat will be written in a separate PR.
Checks