Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An agent implementation of MathChat #1076

Closed
wants to merge 49 commits into from

Conversation

yiranwu0
Copy link
Contributor

@yiranwu0 yiranwu0 commented Jun 10, 2023

Why are these changes needed?

Implement MathChat using the agent framework.

Related issue number

See tasks in #1066. The blog post about MathChat will be written in a separate PR.

Checks

@yiranwu0 yiranwu0 marked this pull request as ready for review June 11, 2023 03:02
Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A significant amount of effort is devoted to handling the python code which seems to be suitable for executing in a Jupyter Notebook environment. Maybe it'll be cleaner to consider implementing an executor based on ipykernel in future.

The current implementation is better than before. To keep this agent in the core library, the following is required:

  1. test code and code coverage
  2. be aware of the maintenance requirement. For example, if we make changes to UserProxyAgent, it may break the MathUserProxyAgent. It could happen that we'll need to temporarily disable it until you make it functional again. You'll also be required to review PRs more timely.

The benefit of including it in the core library is to keep it up-to-date and gets improvement over time (including contributions from follow-up research), until it gets actual usage and makes real impact. The associated cost will be the maintenance effort. Please take these into account and decide whether you'd like to keep it in or out of the core library.

flaml/autogen/agent/math_user_proxy_agent.py Outdated Show resolved Hide resolved
flaml/autogen/agent/math_user_proxy_agent.py Outdated Show resolved Hide resolved
flaml/autogen/agent/math_user_proxy_agent.py Show resolved Hide resolved
flaml/autogen/agent/math_user_proxy_agent.py Outdated Show resolved Hide resolved
flaml/autogen/agent/math_user_proxy_agent.py Show resolved Hide resolved
flaml/autogen/agent/math_user_proxy_agent.py Outdated Show resolved Hide resolved
flaml/autogen/agent/math_user_proxy_agent.py Outdated Show resolved Hide resolved
notebook/autogent_agent_MathChat.ipynb Outdated Show resolved Hide resolved
@qingyun-wu qingyun-wu requested a review from sonichi June 15, 2023 23:55
@qingyun-wu
Copy link
Contributor

typo in the name of the notebook: "autogent_agent_MathChat.ipynb" should be "autogen_agent_MathChat.ipynb"

@yiranwu0 yiranwu0 requested a review from sonichi June 17, 2023 00:25
@sonichi
Copy link
Contributor

sonichi commented Jun 22, 2023

We can disable macos py3.7 test per #1079

Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ready to run the OpenAI test?

.github/workflows/python-package.yml Outdated Show resolved Hide resolved
@sonichi
Copy link
Contributor

sonichi commented Jun 23, 2023

Since py3.7 is removed from test, please remove py3.7 from this badge in README.md:
Python Version

@yiranwu0 yiranwu0 requested a review from sonichi June 23, 2023 14:14
Co-authored-by: Chi Wang <wang.chi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants