-
Notifications
You must be signed in to change notification settings - Fork 119
Merges variants and isenabled paths. Adds variant reason field. #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
87b34df
Adds Reason field and adjusts evaluation logic
rossgrambo e3b2392
merge latest preview branch
zhiyuanliang-ms 6a24277
use enum AssignmentReason
zhiyuanliang-ms 602f32f
add more testcases & remove some interal methods
zhiyuanliang-ms 8e6c14d
fix typo
zhiyuanliang-ms c1094df
update comments
zhiyuanliang-ms 391fef0
resolve comments
zhiyuanliang-ms 263e284
update comment for DisabledDefault
zhiyuanliang-ms 6ff2a4d
fix typo
zhiyuanliang-ms ff0b240
update
zhiyuanliang-ms 6660d09
update telemetry publisher
zhiyuanliang-ms cd1dc64
add reason when no allocation section
zhiyuanliang-ms b26628a
update
zhiyuanliang-ms 4a3f7cf
remove nullable
zhiyuanliang-ms 3007179
resolve comments
zhiyuanliang-ms 3649fd0
update comments
zhiyuanliang-ms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
src/Microsoft.FeatureManagement/Telemetry/VariantAssignmentReason.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT license. | ||
| // | ||
| namespace Microsoft.FeatureManagement.Telemetry | ||
| { | ||
| /// <summary> | ||
| /// The reason the variant was assigned during the evaluation of a feature. | ||
| /// </summary> | ||
| public enum VariantAssignmentReason | ||
| { | ||
| /// <summary> | ||
| /// Variant allocation did not happend. No variant is assigned. | ||
| /// </summary> | ||
| None, | ||
|
|
||
| /// <summary> | ||
| /// The default variant is assigned when a feature flag is disabled. | ||
| /// </summary> | ||
| DefaultWhenDisabled, | ||
|
|
||
| /// <summary> | ||
| /// The default variant is assigned because of no applicable user/group/percentile allocation when a feature flag is enabled. | ||
| /// </summary> | ||
| DefaultWhenEnabled, | ||
|
|
||
| /// <summary> | ||
| /// The variant is assigned because of the user allocation when a feature flag is enabled. | ||
| /// </summary> | ||
| User, | ||
|
|
||
| /// <summary> | ||
| /// The variant is assigned because of the group allocation when a feature flag is enabled. | ||
| /// </summary> | ||
| Group, | ||
|
|
||
| /// <summary> | ||
| /// The variant is assigned because of the percentile allocation when a feature flag is enabled. | ||
| /// </summary> | ||
| Percentile | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always send Variant if assignment reason is not
None. Even if variant is null. So there shouldn't be a need for theif (evaluationEvent.Variant != null)check.