Bug Fix - Avoid duplicated registration of TimeWindowFilter through AddFeatureFilter method #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
Bug fix #447
Visible change
The call of
AddFeatureFilteron theIFeatureManagementBuilderreturned by theAddFeatureManagementcall will no longer registerTimeWindowFilterrepeatedly.This PR added a check in the
AddFeatureFilter<T>()method of theFeatureManagementBuilderclass, if theTisTimeWindowFilter, the method will do nothing.All built-in feature filters are registered during the
AddFeatureManagementcall, theTimeWindowFilteris registered through the overload `AddFeatureFilter(Func implemenetationFactory)The
FeatureManagementBuilderis internal and only be created in theAddFeatureManagmentcall, this ensures that AddFeatureFilter()` will only be called after calling AddFeatureManagement() where the TimeWindowFilter should have been registered.