Port pipeline update to 0.23.x (#3213)

tools/pipelines/build-build-common.yml

@@ -37,3 +37,4 @@ extends:
     taskBuildDocs: false
     taskLint: false
     taskTest: false
+    taskAuth: false

tools/pipelines/build-build-tools.yml

@@ -35,3 +35,5 @@ extends:
     taskBuildDocs: false
     taskLint: false
     taskTest: false
+    taskAuth: false
+    buildNumberInPatch: true

tools/pipelines/build-client.yml

@@ -51,13 +51,21 @@ extends:
     cgSubDirectory: packages
     checkoutSubmodules: true
     preCG:
+    - task: UseNode@1
+      displayName: Use Node 12.x
+      inputs: 
+        version: 12.x    
+    - task: npmAuthenticate@0
+      displayName: 'npm Authenticate root .npmrc'
+      inputs:
+        workingFile: .npmrc
+        customEndpoint: Offnet Packages
     - task: Npm@1
       displayName: npm ci
       inputs:
         command: 'custom'
         customCommand: 'ci --ignore-scripts'
-        customRegistry: 'useFeed'
-        customFeed: '0a22f611-6a4a-4416-a1bb-53ed7284aa21/f56654ac-3b25-4f5c-bd34-2c1b79e8cfa6'
+        customRegistry: 'useNpmrc'
 
     - task: Bash@3
       displayName: 'Generate Mono repo package json'

tools/pipelines/build-eslint-config-fluid.yml

@@ -37,3 +37,4 @@ extends:
     taskBuildDocs: false
     taskLint: false
     taskTest: false
+    taskAuth: false

tools/pipelines/build-generator-fluid.yml

@@ -38,3 +38,5 @@ extends:
     taskLint: false
     taskTest: test
     namespace: false
+    extraAuth: app/templates
+    buildNumberInPatch: true

tools/pipelines/build-test-tools.yml

@@ -34,3 +34,5 @@ extends:
     taskBuildDocs: false
     taskLint: false
     taskTest: false
+    taskAuth: false
+    buildNumberInPatch: true

tools/pipelines/build-tinylicious.yml

@@ -38,3 +38,4 @@ extends:
     taskLint: true
     taskTest: false
     namespace: false
+    buildNumberInPatch: true

tools/pipelines/repo-policy-check.yml

@@ -14,14 +14,28 @@ pr:
 pool:
   vmImage: 'ubuntu-latest'
 
+variables:
+- name: skipComponentGovernanceDetection
+  value: true
+
 steps:
+- task: UseNode@1
+  displayName: Use Node 12.x
+  inputs: 
+    version: 12.x
+
+- task: npmAuthenticate@0
+  displayName: 'npm Authenticate root .npmrc'
+  inputs:
+    workingFile: .npmrc
+    customEndpoint: Offnet Packages
+
 - task: Npm@1
   displayName: npm ci
   inputs:
     command: 'custom'
     customCommand: 'ci --ignore-scripts'
-    customRegistry: 'useFeed'
-    customFeed: '0a22f611-6a4a-4416-a1bb-53ed7284aa21/f56654ac-3b25-4f5c-bd34-2c1b79e8cfa6'
+    customRegistry: 'useNpmrc'
 
 - task: Npm@1
   displayName: Policy Check

tools/pipelines/server-routerlicious.yml

@@ -35,49 +35,71 @@ pr:
     - server/routerlicious/kubernetes/routerlicious
 
 variables:
-  skipComponentGovernanceDetection: true
-  pushImage: ${{
+- name: skipComponentGovernanceDetection
+  value: true
+- name: pushImage
+  value: ${{
     and(
-        ne(variables['Build.Reason'], 'PullRequest'),
-        eq(variables['Build.SourceBranch'], 'refs/heads/master')
+      ne(variables['Build.Reason'], 'PullRequest'),
+      eq(variables['Build.SourceBranch'], 'refs/heads/master')
     )}}
-  registry: prague.azurecr.io
-  containerName: prague-server
-  baseContainerName: $(containerName)-base
-  baseContainerTag: $(baseContainerName):$(Build.BuildId)
-  fullRunnerContainerTag: $(registry)/$(containerName):$(Build.BuildId)
-  ${{ if ne(variables['Build.Reason'], 'PullRequest') }}:
-    testConfig: :full
-  ${{ if eq(variables['Build.Reason'], 'PullRequest') }}:
-    testConfig: :ci
+- group: container-registry-info
+- name: containerName
+  value: fluid-server
+- name: baseContainerName
+  value: $(containerName)-base
+- name: baseContainerTag
+  value: $(baseContainerName):$(Build.BuildNumber)
+- name: fullRunnerContainerTag
+  value: $(containerRegistryUrl)/$(containerName):$(Build.BuildNumber)
+- ${{ if ne(variables['Build.Reason'], 'PullRequest') }}:
+  - name: testConfig
+    value: :full
+- ${{ if eq(variables['Build.Reason'], 'PullRequest') }}:
+  - name: testConfig
+    value: :ci
 
 stages:
 - stage: build
   displayName: Build Stage
   jobs:
     - job: build
       displayName: Build - Server
-      pool: Default
+      pool: Main
       steps:
         # Checkout
         - checkout: self
           clean: true
           lfs: false
           submodules: false
 
+        - task: Bash@3
+          displayName: Strip MIT License
+          inputs:
+            targetType: 'inline'
+            workingDirectory: server/routerlicious
+            script: |
+              sed -i '/^.*Licensed under the MIT License.$/d' `find -type f | grep -v '^\.\/\.'`
+              perl -i -0pe 's/,\n.*"license": "MIT"//g' `find | grep package.json`
+              git status
+
         # Component detection (not pull request)
         - ${{ if ne(variables['Build.Reason'], 'PullRequest') }}:
+          - task: UseNode@1
+            displayName: Use Node 12.x
+            inputs: 
+              version: 12.x
           - task: npmAuthenticate@0
             displayName: 'npm Authenticate root .npmrc'
             inputs:
               workingFile: .npmrc
+              customEndpoint: Offnet Packages
           - task: Npm@1
             displayName: npm ci
             inputs:
               command: 'custom'
               customCommand: 'ci --ignore-scripts'
-              customRegistry: 'useFeed'
-              customFeed: '0a22f611-6a4a-4416-a1bb-53ed7284aa21/f56654ac-3b25-4f5c-bd34-2c1b79e8cfa6'
+              customRegistry: 'useNpmrc'
           - bash: |
               # Generate the package/package lock for the lerna project so we would scan it.
               node node_modules/@fluidframework/build-tools/dist/genMonoRepoPackageJson/genMonoRepoPackageJson.js
@@ -104,6 +126,7 @@ stages:
           displayName: npm Authenticate
           inputs:
             workingFile: server/routerlicious/.npmrc
+            customEndpoint: Offnet Packages
 
         # Build
         - task: Docker@2
@@ -113,9 +136,9 @@ stages:
             command: build
             dockerFile: server/routerlicious/Dockerfile
             buildContext: server/routerlicious
-            arguments: --target base --build-arg VERSION_BUILDNUMBER=$(Build.BuildId) --build-arg VERSION_BUILDBRANCH=$(Build.SourceBranch)
+            arguments: --target base --build-arg VERSION_BUILDNUMBER=$(Build.BuildNumber) --build-arg VERSION_BUILDBRANCH=$(Build.SourceBranch)
             tags: |
-              $(Build.BuildId)
+              $(Build.BuildNumber)
 
         # Pack
         - task: Docker@0
@@ -180,23 +203,23 @@ stages:
           - task: Docker@2
             displayName: 'Docker Build - Runner'
             inputs:
-              containerRegistry: Fluid Azure Container Registry
+              containerRegistry: $(containerRegistryConnection)
               repository: $(containerName)
               command: build
               dockerFile: server/routerlicious/Dockerfile
               buildContext: server/routerlicious
-              arguments: '--target runner --build-arg VERSION_BUILDNUMBER=$(Build.BuildId) --build-arg VERSION_BUILDBRANCH=$(Build.SourceBranch)'
+              arguments: '--target runner --build-arg VERSION_BUILDNUMBER=$(Build.BuildNumber) --build-arg VERSION_BUILDBRANCH=$(Build.SourceBranch)'
               tags: |
-                $(Build.BuildId)
+                $(Build.BuildNumber)
           
           - task: Docker@2
             displayName: 'Docker Push - Runner'
             inputs:
-              containerRegistry: Fluid Azure Container Registry
+              containerRegistry: $(containerRegistryConnection)
               repository: $(containerName)
               command: push
               tags: |
-                $(Build.BuildId)
+                $(Build.BuildNumber)
 
         # Cleanup
         - task: Docker@0
@@ -235,6 +258,7 @@ stages:
         feeds:
         - name: https://offnet.pkgs.visualstudio.com/officenet/_packaging/fluid/npm/registry/
           environment: fluid-feed
+          customEndPoint: Offnet Packages
           internal: false
         # only publish release bits
         - ${{ if startsWith(variables['Build.SourceBranch'], 'refs/tags/') }}:

tools/pipelines/templates/build-docker-service.yml

@@ -28,26 +28,26 @@ parameters:
 trigger: none
 
 variables:
-  skipComponentGovernanceDetection: true
-  pushImage: ${{
-    and(
-      ne(variables['Build.Reason'], 'PullRequest'),
-      eq(variables['Build.SourceBranch'], 'refs/heads/master')
-    )}}
-  generateNotice: ${{ ne(variables['Build.Reason'], 'PullRequest') }}
-  registry: prague.azurecr.io
-  baseContainerTag: ${{ parameters.containerName }}:$(Build.BuildId)
-  ${{ if eq(variables.pushImage, false) }}:
-    containerRegistry:
-    containerTag: $(baseContainerTag)
-  ${{ if eq(variables.pushImage, true) }}:
-    containerRegistry: Fluid Azure Container Registry
-    containerTag: $(registry)/$(baseContainerTag)
+- name: skipComponentGovernanceDetection
+  value: true
+- name: pushImage
+  value: ${{ ne(variables['Build.Reason'], 'PullRequest') }}
+- name: generateNotice
+  value: ${{ ne(variables['Build.Reason'], 'PullRequest') }}
+- group: container-registry-info
+- name: baseContainerTag
+  value: ${{ parameters.containerName }}:$(Build.BuildNumber)
+- ${{ if eq(variables.pushImage, false) }}:
+  - name: containerTag
+    value: $(baseContainerTag)
+- ${{ if eq(variables.pushImage, true) }}:
+  - name: containerTag
+    value: $(containerRegistryUrl)/$(baseContainerTag)
 
 jobs:
   - job: build
     displayName: Build Container - ${{ parameters.containerName }}
-    pool: Shared
+    pool: Lite
     steps:
     # Setup
     - checkout: self
@@ -75,18 +75,19 @@ jobs:
         displayName: 'npm Authenticate ${{ parameters.buildDirectory }}/.npmrc'
         inputs:
           workingFile: ${{ parameters.buildDirectory }}/.npmrc
+          customEndpoint: Offnet Packages
 
     # Build
     - task: Docker@2
       displayName: Docker Build
       inputs:
-        containerRegistry: $(containerRegistry)
+        containerRegistry: $(containerRegistryConnection)
         repository: ${{ parameters.containerName }}
         command: build
         dockerFile: ${{ parameters.buildDirectory }}/Dockerfile
         buildContext: ${{ parameters.buildDirectory }}
         tags: |
-          $(Build.BuildId)
+          $(Build.BuildNumber)
 
     # Lint
     - ${{ if eq(parameters.lint, true) }}:
@@ -125,11 +126,11 @@ jobs:
       - task: Docker@2
         displayName: Docker Push
         inputs:
-          containerRegistry: $(containerRegistry)
+          containerRegistry: $(containerRegistryConnection)
           repository: ${{ parameters.containerName }}
           command: push
           tags: |
-            $(Build.BuildId)
+            $(Build.BuildNumber)
 
     # Cleanup
     - task: Docker@0

tools/pipelines/templates/build-docs-steps.yml

@@ -66,19 +66,23 @@ steps:
     OverWrite: false
     flattenFolders: true
     CleanTargetFolder: true
-
+
+- task: UseNode@1
+  displayName: Use Node 12.x
+  inputs:
+    version: 12.x
 - task: npmAuthenticate@0
   displayName: 'npm Authenticate root .npmrc'
   inputs:
     workingFile: .npmrc
+    customEndpoint: Offnet Packages
 
 - task: Npm@1
   displayName: npm ci
   inputs:
     command: 'custom'
     customCommand: 'ci --ignore-scripts'
-    customRegistry: 'useFeed'
-    customFeed: '0a22f611-6a4a-4416-a1bb-53ed7284aa21/f56654ac-3b25-4f5c-bd34-2c1b79e8cfa6'
+    customRegistry: 'useNpmrc'
 
 # Build the docs site
 - task: Docker@2