-
Notifications
You must be signed in to change notification settings - Fork 536
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Deprecate enableGroupedBatching (#23260)
## Description After discussing the work in task [#8124](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/8124), we concluded that it was best to make Batch Grouping dependent on Batch Compression. This is the first step where we are tagging enableGroupedBatching as deprecated in containerRuntime.ts Acceptance Criteria: containerRuntime.enableGroupedBatching is now tagged as deprecated Execution Plan: Create the changeset file explaining the change and add the @deprecated tag ## Reviewer Guidance Please let me know if there's anything I should change or make better. Fixes [AB#26356](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/26356)
- Loading branch information
1 parent
0512e74
commit 49d8e75
Showing
3 changed files
with
16 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
--- | ||
"@fluidframework/container-runtime": minor | ||
"@fluidframework/fluid-static": minor | ||
--- | ||
--- | ||
"section": deprecation | ||
--- | ||
|
||
IContainerRuntimeOptions.enableGroupedBatching is now deprecated | ||
|
||
The `IContainerRuntimeOptions.enableGroupedBatching` property is deprecated and will be removed in version 2.20.0. This will mean that the grouped batching feature can no longer be disabled. In versions 2.20.0 and beyond, grouped batching is required for the proper functioning of the Fluid Framework. | ||
|
||
The sole case where grouped batching will be disabled is for compatibility with older v1 clients, and this will be implemented without any need for the configurable `IContainerRuntimeOptions.enableGroupedBatching` option. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters