Skip to content

Commit

Permalink
Remove audience error logging in container (#7014)
Browse files Browse the repository at this point in the history
Fixes #6910
We're frequently hitting the race condition on initial connection (such as with transition from read to write client) where a client disconnects very close to when another client connects, and the disconnect audience signal is sent to the connecting client that never knew about the disconnecting client. This is obfuscating what we really want to check (mismatched audience join/leaves e.g. legitimately lost signals), so just remove it because it's nbd(TM) (jk see the attached bug for more info)
  • Loading branch information
heliocliu authored Aug 7, 2021
1 parent af719ff commit f6829e7
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions packages/loader/container-loader/src/container.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1779,9 +1779,7 @@ export class Container extends EventEmitterWithErrorHandling<IContainerEvents> i
this._audience.addMember(newClient.clientId, newClient.client);
} else if (innerContent.type === MessageType.ClientLeave) {
const leftClientId = innerContent.content as string;
if (!this._audience.removeMember(leftClientId)) {
this.logger.sendErrorEvent({ eventName: "MissingAudienceMember", clientId: leftClientId });
}
this._audience.removeMember(leftClientId);
}
} else {
const local = this.clientId === message.clientId;
Expand Down

0 comments on commit f6829e7

Please sign in to comment.