Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose component "type" on returned ComponentContext #1123

Closed
leeviana opened this issue Feb 3, 2020 · 2 comments · Fixed by #1220
Closed

Expose component "type" on returned ComponentContext #1123

leeviana opened this issue Feb 3, 2020 · 2 comments · Fixed by #1220
Assignees
Labels
api area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct good first issue Good for newcomers
Milestone

Comments

@leeviana
Copy link
Contributor

leeviana commented Feb 3, 2020

It would be useful to have access to the component "type" (the string passed to the registry to resolve the component code) when we load a component (right now, just for logging purposes).

For example when an instance of a tablero is resolved in our container, we want access the string that looks something like "@ms/tablero" that was passed into the ContainerRegistry.

@leeviana
Copy link
Contributor Author

leeviana commented Feb 3, 2020

@anthony-murphy and @agarwal-navin

@tylerbutler tylerbutler added the area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct label Feb 3, 2020
@curtisman curtisman added the api label Feb 3, 2020
@curtisman curtisman added this to the Build 2020 milestone Feb 3, 2020
@skylerjokiel skylerjokiel self-assigned this Feb 4, 2020
@skylerjokiel skylerjokiel added the good first issue Good for newcomers label Feb 4, 2020
@skylerjokiel skylerjokiel changed the title Expose component "type" on returned component value (or component runtime) Expose component "type" on returned ComponentContext Feb 7, 2020
@skylerjokiel
Copy link
Contributor

To add clarity here. We want to expose both the package "type" and the package "path" on the IComponentContext. This can then be exposed to the Container or other components via the component itself if it chooses to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants