Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update createComponent in externalComponentLoader.ts to use the current component's path instead of WaterParkLoaderName #1208

Closed
agarwal-navin opened this issue Feb 7, 2020 · 0 comments · Fixed by #1220
Closed

Update createComponent in externalComponentLoader.ts to use the current component's path instead of WaterParkLoaderName #1208

agarwal-navin opened this issue Feb 7, 2020 · 0 comments · Fixed by #1220
Assignees
@agarwal-navin
Labels
area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct
Milestone
February 2020

Comments

@agarwal-navin
Copy link
Contributor

#1188 removed createSubComponent from IComponentContext. So, to create a component with a specific package path, createComponent or _createComponentWithProps in IHostRuntime is to be used.
ExternalComponentLoader was using createSubComponent to create a component relative to the current component's path. It was changed to use createComponent by prepending WaterParkLoaderName (as the root component name). This works for now but it needs to be changed to get the path of the current component.

Once #1123 is checked in, we can use it to get the current component's path and use that instead of WaterParkLoaderName.
@agarwal-navin agarwal-navin self-assigned this Feb 7, 2020
@curtisman curtisman added this to the February 2020 milestone Feb 10, 2020
@curtisman curtisman added isomorphic Client/server isomorphic usage issues area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct and removed isomorphic Client/server isomorphic usage issues labels Feb 10, 2020
@agarwal-navin agarwal-navin mentioned this issue Feb 10, 2020
Merged
@snyk-bot snyk-bot mentioned this issue Nov 4, 2022
Open
This was referenced Nov 4, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Nov 4, 2022
Open
This was referenced Nov 4, 2022
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 5, 2022
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Nov 5, 2022
Open
@MarcelRaschke MarcelRaschke mentioned this issue Nov 5, 2022
Open
This was referenced Nov 5, 2022
Open
Open
This was referenced Nov 5, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
jason-ha pushed a commit that referenced this issue Jan 23, 2025
@dependabot
build(deps-dev): Bump webpack from 5.95.0 to 5.96.1 in /brainstorm (#…
b758cc5 
…1208)

Bumps [webpack](https://github.com/webpack/webpack) from 5.95.0 to 5.96.1.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.95.0...v5.96.1)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agarwal-navin agarwal-navin

Labels
area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct
Projects
None yet
Milestone
February 2020
Development

Successfully merging a pull request may close this issue.

Exposed package "path" on IComponentContext.
2 participants
@curtisman @agarwal-navin