Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summarization error when switching between documents in fluid preview app #1615

Closed
vladsud opened this issue Mar 24, 2020 · 3 comments
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@vladsud
Copy link
Contributor

vladsud commented Mar 24, 2020

I believe the reason for the error - me switching documents (actually - creating a new doc while old one was summarizing).
I think it would be nice not to issue error (i.e. category="error") as this is not really an error, but rather normal flow of events. Or better - keep summarizing :)

image

@vladsud vladsud added the bug Something isn't working label Mar 24, 2020
@vladsud vladsud added this to the April 2020 milestone Mar 24, 2020
@ghost ghost added the triage label Mar 24, 2020
@curtisman curtisman removed the triage label Mar 24, 2020
@arinwt
Copy link
Contributor

arinwt commented Mar 24, 2020

Easy fix is to handle the promise rejection of timer cancel (or change PromiseTimers to resolve and handle that flow).

Keeping summarizer client running I would mark as related to #931. Though this part could be done independently, if we break the simple concept of keeping summarizer client alive only while main client is alive, then we should at least be thinking about consequences.

@arinwt
Copy link
Contributor

arinwt commented Apr 14, 2020

Mostly addressed in #1729. Specifically, the "UnexpectedSummarizeError" mentioned above. Leaving this issue open, because there is one other place it can happen, and probably should just change how timers work to never reject. This might mean changing the API of timers as well, or at least the async PromiseTimers.

@arinwt arinwt modified the milestones: April 2020, May 2020 May 4, 2020
@curtisman curtisman modified the milestones: May 2020, June 2020 Jun 1, 2020
@arinwt
Copy link
Contributor

arinwt commented Jun 3, 2020

This should be fixed by #2368 and #770 which changed PromiseTimer to always resolve.

@arinwt arinwt closed this as completed Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants