One last summary before closing [0.15]

[arinwt]

fixes #643

Part 1: SummaryManager eliminates initial delay before spawning summarizer if client join message op seq is much greater than deltaManager.initialSequenceNumber (4k ops right now, to ensure below 5k server limit of ODSP).

Part 2: Summarizer added async waitStop function to RunningSummarizer and await that before closing the entire container when the Summarizer gets stopped. New flow is:

1. Main client disconnects, so its SummaryManager calls Summarizer.stop
2. Summarizer.stop raises an event and completes the runCore deferred (essentially)
3. Completing runCore, if connected: awaits runningSummarizer.waitStop and then closes the container
4. Then everything is disposed

This should work with the other flow when the summarizer client disconnects first:

1. Summarizer client disconnects, so the runCore deferred completes (essentially)
2. Completing runCore disposes everything (since the container is not connected).

Also with the prevention of re-entrancy in Summarizer stop, it should work with the fallback validation in generateSummary.

This required a small relaxation of the fallback Summarizer generateSummary check that its parent client is still the elected summarizer client. Now it also allows that the itself is the elected summarizer, i.e. the only client on the document (because others would be elected summarizer).

Additional work:

• Fix missing clientType info during request Container creation (already attached) by setting originalRequest in constructor so it is set first before calling get client() @vladsud @jatgarg - can you guys verify this part? (commit: 6995ef0 in this PR)
  edit: after resolving conflicts, it looks like this was already resolved in the same way :)
• Prevent SummaryManager from spawning a new summarizer if there is any summarizer already in the quorum. This keeps other interactive clients from trying to spawn a summarizer if there is a lingering one trying to summarize one last time.
• Since we don't wait for summary ack before closing the summarizer, make sure not to throw errors on timeout timer cancels in summarize.

[vladsud]

        return;

Should this code be reorganized a bit?
Like can we here return this.summarizing.promise, and code in waitStop() just call trySummarizeCore() ?

---

Refers to: packages/runtime/container-runtime/src/summarizer.ts:453 in c216621. [](commit_id = c216621, deletion_comment = False)

[vladsud]

[arinwt]

        return;

I think I understand what you're suggesting...
Perhaps as it is now, it's a bit hacky, but this.summarizing.promise resolves sooner than trySummarizeCore(), so the code might end up getting a little messy.

---

In reply to: 610468953 [](ancestors = 610468953)

---

Refers to: packages/runtime/container-runtime/src/summarizer.ts:453 in c216621. [](commit_id = c216621, deletion_comment = False)