-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Re)Remove _createDataStoreWithProps from dataStoreContext.ts #3631
Comments
#3631 Minimally restore _createDataStoreWithProps. This includes adding back the API and adding back passing initial configs through the context. Bohemia isn't quite ready to move off this API yet but they will be soon™. Future: port this change to 0.26 and main branches as well (Bohemia is not expected to be ready by 0.27 release)
#3631 Port earlier change to minimally restore _createDataStoreWithProps to main. Differences from 0.26 port include a minor merge conflict around a different added arg in LocalDataStoreContext ctor
@leeviana is bohemia ready for the new create flow? is this something that can be done for november and consumed in 0.29? |
We still set the rootcomponentconfig during initializingfirsttime. Since our office container now supports different root configs, we still allow for initialConfigs to be used for those components. We could go back to what we had years ago (IComponentWithInitialConfig) but is this really what is recommended for generic initial config values for all components? |
IComponentWithInitialConfig kind of sounds like a step backward? If more time is needed to get it right that's fine (especially since Vlad has more related changes in the pipe that may affect this); just wondering if this item is ready to do |
IComponentWithInitialConfig is essentially what scriptor is hacking now but I think for this issue we only care about root component creations. @cristighr1995 does it make sense to take in root component config (canvas component type + initial config for canvas component) on some sort of Canvas related provider interface method instead of the initial config? |
This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework! |
Related: #8292 |
@heliocliu @vladsud can you help us clarify what the original intention was with this deprecation. @leeviana has shared her comments here: #8292, and that ticket would be covered with the solution that we determine here (around Partner repos seem to be relying on @vladsud I have seen related changes here: #4163. It still seems that partners would need to deal directly with aqueduct/dataobjecy factory APIs to setup |
This API along with the supporting context props were removed in #2931 and #2951 but Bohemia was not prepared to receive these blessings in the 0.25 release and they needed to be added back in. We expect they might be ready by 0.27
The text was updated successfully, but these errors were encountered: