-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
socketDocumentId on connection errors #4143
Comments
@ksbrar , @skylerjokiel - FYI, I think that's trivial change that can speed up investigation of connection issues reported by Dan & Kyle. |
curtisman
added
telemetry
area: driver
Driver related issues
and removed
bug
Something isn't working
triage
labels
Oct 28, 2020
ghost
added
the
triage
label
Oct 28, 2020
This was referenced Aug 18, 2022
Open
This was referenced Aug 18, 2022
Open
This was referenced Aug 18, 2022
Open
Open
Open
Open
This was referenced Aug 18, 2022
Open
This was referenced Aug 19, 2022
Open
This was referenced Aug 19, 2022
This was referenced Aug 19, 2022
This was referenced Aug 19, 2022
This was referenced Aug 19, 2022
This was referenced Aug 19, 2022
This was referenced Aug 19, 2022
This was referenced Aug 19, 2022
This was referenced Aug 20, 2022
Open
Open
This was referenced Aug 20, 2022
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have a bunch of reports where we fail to connect to ordering service in SPO driver and we have no correlation ID to connect with server logs.
We have successful joinSesison call, and thus ISocketStorageDiscovery.id that we report (on successful path) as socketDocumentId in the rest of our telemetry.
But here, connection fails, so we never report any correlation ID (this one, or clientID), and thus we have nothing to work with.
Can OdspDocumentService.connectToDeltaStream() add socketDocumentId property to error object before it re-throws it?
I believe that's enough to get all the data we need.
If possible, we should fast-track it into 0.27 to faster understand the problem.
The text was updated successfully, but these errors were encountered: