Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add websocketDocID to error so that it gets logged in telemetry #4172

Merged
merged 3 commits into from
Oct 29, 2020

Conversation

jatgarg
Copy link
Contributor

@jatgarg jatgarg commented Oct 29, 2020

Fixes: #4143

@jatgarg jatgarg added area: driver Driver related issues telemetry labels Oct 29, 2020
@jatgarg jatgarg requested a review from vladsud October 29, 2020 22:26
@jatgarg jatgarg self-assigned this Oct 29, 2020
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Oct 29, 2020

@fluidframework/base-host: No change
Metric NameBaseline SizeCompare SizeSize Diff
main.js 163.58 KB 163.58 KB No change
Total Size 163.58 KB 163.58 KB No change
@fluid-example/bundle-size-tests: +56 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
container.js 180.09 KB 180.09 KB No change
map.js 39.79 KB 39.79 KB No change
matrix.js 137.45 KB 137.45 KB No change
odspDriver.js 191.42 KB 191.48 KB +56 Bytes
sharedString.js 167.6 KB 167.6 KB No change
Total Size 716.36 KB 716.41 KB +56 Bytes

Baseline commit: 16859ae

Generated by 🚫 dangerJS against ccb8482

@jatgarg
Copy link
Contributor Author

jatgarg commented Oct 29, 2020

Also do we need to put this in 0.27? @vladsud

@vladsud
Copy link
Contributor

vladsud commented Oct 29, 2020

I think we have got more clarity on why things break, so no, no need to rush into 0.27

@jatgarg jatgarg merged commit d746f91 into microsoft:main Oct 29, 2020
@jatgarg jatgarg deleted the socket branch October 30, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: driver Driver related issues telemetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

socketDocumentId on connection errors
3 participants