Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate - DDSs that don't explicitly serialize handles do not allow handles to be in its data #4329

Closed
agarwal-navin opened this issue Nov 13, 2020 · 3 comments
Labels
area: dds Issues related to distributed data structures
Milestone

Comments

@agarwal-navin
Copy link
Contributor

From #3975 (comment)

DDSs such as Ink, Counter, SharedSummaryBlock do not serialize any handles. This issue it to investigate and make sure that they do not support handles in their data. Otherwise this should break GC which (currently) requires handles to be serialized.

@tylerbutler
Copy link
Member

@agarwal-navin Have these DDSes been reviewed to see if they need handle support? Should there be some type-level way of expressing this? E.g. DDSes like this implement ICantStoreHandles or something like that?

@agarwal-navin
Copy link
Contributor Author

I don't think the have. The idea behind this work item is that if a DDS does not support handles, we should have some way of validating that the data being stored is not a handle. I am not sure how we enforce that but this work is about coming up with that plan.
For example, a new DDS added should either support handles or not and we should make sure the right thing happens when data is added to the DDS.

@agarwal-navin
Copy link
Contributor Author

agarwal-navin commented May 24, 2022

Tracked by AB#407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds Issues related to distributed data structures
Projects
None yet
Development

No branches or pull requests

2 participants