-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added summarize() API in DDS that generates summary tree and list of referenced routes #3975
Conversation
@vladsud @anthony-murphy With this change, do we still need the IFluidSerializer at ContainerRuntime and DataStoreRuntime? I don't see them getting used in our code or in Bohemia's. I do see that IFluidObject extends IProvideFluidSerializer but I am not sure if we need it. |
■ @fluidframework/base-host: No change
⯅ @fluid-example/bundle-size-tests: +22.16 KB
Baseline commit: a8e56c3 |
that doesn't look right. is it supposed to an issue |
Updated it to reflect the correct issue. |
@anthony-murphy Did I delete your comment in SharedObject? I was replying to it and I refreshed the page. Now, its gone! |
40b1ff8
to
80b9ac6
Compare
Closing and reopening to trigger build |
80b9ac6
to
d9baa09
Compare
d9baa09
to
365bb67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must admit I reviewed it in chunks, between various commits, but overall looks good.
Thanks Vlad! We can keep iterating on it as and when needed. |
…er to be used to serialize handles during snapshot
…erializer to each DDS
…one is a separate PR
82a97fb
to
21f1f25
Compare
Fixes #3967
This is a pre-cursor to garbage collection.
A follow up PR will use the routes tracked during the snapshot process for use during GC.