Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Udpate summarize in SharedObject to return IChannelSummarizeResult #4431

Closed
agarwal-navin opened this issue Nov 20, 2020 · 0 comments
Closed

Udpate summarize in SharedObject to return IChannelSummarizeResult #4431

agarwal-navin opened this issue Nov 20, 2020 · 0 comments
Assignees
@agarwal-navin
Labels
area: dds Issues related to distributed data structures
Milestone
November 2020

Comments

@agarwal-navin
Copy link
Contributor

I added summarize method to SharedObject in #3975. It has to be updated to return IChannelSummarizeResult to be in sync with the other summarize APIs. This means returning garbage collection nodes as part of the result.
Also, update unit tests to use summarize instead of snapshot.
@agarwal-navin agarwal-navin added the area: dds Issues related to distributed data structures label Nov 20, 2020
@agarwal-navin agarwal-navin added this to the November 2020 milestone Nov 20, 2020
@agarwal-navin agarwal-navin self-assigned this Nov 20, 2020
@agarwal-navin agarwal-navin mentioned this issue Nov 20, 2020
Merged
@agarwal-navin agarwal-navin changed the title Udpated summarize in SharedObject to return IChannelSummarizeResult Udpate summarize in SharedObject to return IChannelSummarizeResult Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agarwal-navin agarwal-navin

Labels
area: dds Issues related to distributed data structures
Projects
None yet
Milestone
November 2020
Development

No branches or pull requests
1 participant
@agarwal-navin