Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maxThrottlingDelay becomes invalid as time goes by in deltamanager. We need to clear it if it becomes invalid. #4518

Closed
jatgarg opened this issue Dec 3, 2020 · 0 comments · Fixed by #4527
Closed

maxThrottlingDelay becomes invalid as time goes by in deltamanager. We need to clear it if it becomes invalid. #4518

jatgarg opened this issue Dec 3, 2020 · 0 comments · Fixed by #4527
Assignees
@jatgarg
Labels
area: loader Loader related issues bug Something isn't working
Milestone
December 2020

Comments

@jatgarg
Copy link
Contributor

jatgarg commented Dec 3, 2020

This is existing bug, but can you please open an issue to fix it?
The problem is that as time goes by this.maxThrottlingDelay becomes invalid. Instead we should be tracking point in time when it's going to end (i.e. not delay, but actual time).

Originally posted by @vladsud in #4427 (comment)
@ghost ghost added the triage label Dec 3, 2020
@jatgarg jatgarg changed the title This is existing bug, but can you please open an issue to fix it? maxThrottlingDelay becomes invalid as time goes by in deltamanager. We need to clear it if it becomes invalid. Dec 3, 2020
@jatgarg jatgarg self-assigned this Dec 3, 2020
@jatgarg jatgarg added the area: loader Loader related issues label Dec 3, 2020
@jatgarg jatgarg added this to the December 2020 milestone Dec 3, 2020
@ghost ghost added triage and removed triage labels Dec 3, 2020
@jatgarg jatgarg removed the triage label Dec 3, 2020
@curtisman curtisman added the bug Something isn't working label Dec 3, 2020
@jatgarg jatgarg mentioned this issue Dec 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jatgarg jatgarg

Labels
area: loader Loader related issues bug Something isn't working
Projects
None yet
Milestone
December 2020
Development

Successfully merging a pull request may close this issue.

Change logic for throttling limit to time in future in delta manager jatgarg/FluidFramework-1
2 participants
@curtisman @jatgarg