-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry reads for blobs and trees if we can retry because of skeleton snapshots. #4427
Conversation
⯅ @fluidframework/base-host: +1.37 KB
■ @fluid-example/bundle-size-tests: No change
Baseline commit: c03a8b2 |
packages/loader/container-loader/src/prefetchDocumentStorageService.ts
Outdated
Show resolved
Hide resolved
packages/loader/container-loader/src/retriableDocumentStorageService.ts
Outdated
Show resolved
Hide resolved
packages/loader/container-loader/src/retriableDocumentStorageService.ts
Outdated
Show resolved
Hide resolved
packages/loader/container-loader/src/retriableDocumentStorageService.ts
Outdated
Show resolved
Hide resolved
packages/loader/container-loader/src/prefetchDocumentStorageService.ts
Outdated
Show resolved
Hide resolved
packages/loader/container-loader/src/retriableDocumentStorageService.ts
Outdated
Show resolved
Hide resolved
packages/loader/container-loader/src/retriableDocumentStorageService.ts
Outdated
Show resolved
Hide resolved
packages/loader/container-loader/src/retriableDocumentStorageService.ts
Outdated
Show resolved
Hide resolved
Adding a bit more background about the defect: |
Related to issue: #3963
With odsp driver moving to skeleton snapshots, we won't fetch compete snapshot as trees latest call and we don't do that already for r11s. So runtime should retry blob/tree read on retriable failures.
Provide the utility to retry on failures.