Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade node-fetch dependency to address component governance alert #4708

Closed
christiango opened this issue Jan 4, 2021 · 0 comments · Fixed by #4719
Closed

Upgrade node-fetch dependency to address component governance alert #4708

christiango opened this issue Jan 4, 2021 · 0 comments · Fixed by #4719
Labels
bug Something isn't working dependencies Pull requests that update a dependency file

Comments

@christiango
Copy link
Member

@fluid-framework/webpack-fluid-loader has a dependency on axios 1.7.3 via @fluid-framework/web-code-loader via isomorphic-fetch. This is triggering a component governance alert in the office repos that can be addressed by upgrading to axios >=2.6.1.

Here is the security alert (marked as low severity, but still should be addressed):
GHSA-w7rc-rwvf-8q5r
@christiango christiango added the bug Something isn't working label Jan 4, 2021
@ghost ghost added the triage label Jan 4, 2021
@christiango christiango changed the title Upgrade node-fetch dependency to address component-governance alert Upgrade node-fetch dependency to address component governance alert Jan 4, 2021
@curtisman curtisman added the dependencies Pull requests that update a dependency file label Jan 5, 2021
@curtisman curtisman mentioned this issue Jan 5, 2021
Merged
curtisman added a commit that referenced this issue Jan 5, 2021
@curtisman
Update isomorphic-fetch and node-fetch versions (#4719)
5613b11 
Fix #4708

Also build-tool version as well.
@curtisman curtisman removed the triage label Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update isomorphic-fetch and node-fetch versions curtisman/FluidFramework
2 participants
@christiango @curtisman