Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bindToContext from data store interfaces. #7895

Closed
agarwal-navin opened this issue Oct 19, 2021 · 4 comments · Fixed by #8269
Closed

Remove bindToContext from data store interfaces. #7895

agarwal-navin opened this issue Oct 19, 2021 · 4 comments · Fixed by #8269
Assignees
@agarwal-navin
Labels
api deprecation Changes to a deprecated API area: runtime: gc Garbage collection related work
Milestone
Future

Comments

@agarwal-navin
Copy link
Contributor

attachGraph should instead be used to attach the data store runtime to the context. bindToContext should be a subset of operations done by attachGraph.
@agarwal-navin
Copy link
Contributor Author

@vladsud FYI

@agarwal-navin agarwal-navin mentioned this issue Oct 20, 2021
Merged
@vladsud
Copy link
Contributor

vladsud commented Oct 20, 2021

So I assume this issue will track removal, while above mentioned PR will track deprecation.
So moving it to Nov (as we could make it happen 2 releases from now, which is 10 days from now with the right timing :)

@vladsud vladsud added this to the November 2021 milestone Oct 20, 2021
@vladsud vladsud removed their assignment Oct 20, 2021
This was referenced Oct 22, 2021
Closed
Closed
@agarwal-navin agarwal-navin added the area: runtime: gc Garbage collection related work label Oct 26, 2021
@agarwal-navin agarwal-navin mentioned this issue Nov 16, 2021
Merged
@agarwal-navin
Copy link
Contributor Author

The fix has been reverted.

@agarwal-navin agarwal-navin reopened this Nov 19, 2021
@agarwal-navin agarwal-navin modified the milestones: March 2022, Future Mar 4, 2022
@sonalivdeshpande sonalivdeshpande added the api deprecation Changes to a deprecated API label Mar 11, 2022
@agarwal-navin
Copy link
Contributor Author

agarwal-navin commented May 23, 2022 •
edited by azure-boards bot
Loading

Tracked by AB#385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agarwal-navin agarwal-navin

Labels
api deprecation Changes to a deprecated API area: runtime: gc Garbage collection related work
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Removed bindToContext from IFluidDataStoreChannel agarwal-navin/FluidFramework
3 participants
@agarwal-navin @sonalivdeshpande @vladsud