Removed bindToContext from IFluidDataStoreChannel #8269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: runtime
anthony-murphy
approved these changes
Nov 16, 2021
vladsud
reviewed
Nov 16, 2021
| @@ -429,17 +429,17 @@ IFluidDataStoreChannel, IFluidDataStoreRuntime, IFluidHandleContext { | |||
| }); | |||
|
|
|||
| this.localChannelContextQueue.clear(); | |||
| this.bindToContext(); | |||
| this.updateBindState(); | |||
There was a problem hiding this comment.
Can we instead inline the call and get rid of this.bindState? I think (given that's the only entry point) that we ensure it's called only once, so no need to track it? In places where it's tested, can we leverage appropriate this.graphAttachState states?
There was a problem hiding this comment.
Good point. Removed it. Can you please take a look if the logic looks correct now.
There was a problem hiding this comment.
Looks good to me - one less concept to think about!
There was a problem hiding this comment.
Yes, exactly. Now we just need to rename graphAttachState!
vladsud
approved these changes
Nov 17, 2021
agarwal-navin
added a commit
to agarwal-navin/FluidFramework
that referenced
this pull request
Nov 19, 2021
agarwal-navin
added a commit
that referenced
this pull request
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7895 and #7927.
IFluidDataStoreChannel::bindToContext was deprecated in 0.50. This has now been removed.
Also, removed
bindStatetracking from data store runtime since that is now a duplicate of graphAttachState.