Type validate runtime definition packages #8313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: runtime
anthony-murphy
requested review from
heliocliu,
agarwal-navin,
ChumpChief and
skylerjokiel
…to type-validate-runtime-defs
heliocliu
approved these changes
Nov 18, 2021
…to type-validate-runtime-defs
anthony-murphy
force-pushed
the
type-validate-runtime-defs
branch
from
2ac3b6d to
ff5b652
Compare
…to type-validate-runtime-defs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as part of #7613 i'm making a number of type changes that should be backwards and forward compat, but i'd like to have validation for this.
the existing backcompat suppressions are due to #8269. My changes for #7613 will help prevent sprawling breaks due IFluidObject which is part of the issue here