Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace createCreateNewRequest with createOdspCreateContainerRequest #8223

Closed
Tracked by #8005
sonalivdeshpande opened this issue Nov 10, 2021 · 1 comment · Fixed by #8233
Closed
Tracked by #8005

Replace createCreateNewRequest with createOdspCreateContainerRequest #8223

sonalivdeshpande opened this issue Nov 10, 2021 · 1 comment · Fixed by #8233
Assignees
Milestone

Comments

@sonalivdeshpande
Copy link
Contributor

sonalivdeshpande commented Nov 10, 2021

Overview

The createCreateNewRequest function should be replaced with createOdspCreateContainerRequest function in odsp-driver package.

Proposed Solution

There are few instances where the createCreateNewRequest function is used in Fluid Framework repository. The function is not being used in other internal repositories (FluidExamples, Bohemia, OneNote). The function can be replaced with createOdspCreateContainerRequest function and updated in BREAKING.md.

Methodology

The createCreateNewRequest function is removed from the following files:

  1. packages\drivers\odsp-driver\src\odspDriverUrlResolver.ts
  2. packages\drivers\odsp-driver\src\odspDriverUrlResolverForShareLink.ts

The createCreateNewRequest function is replaced with createOdspCreateContainerRequest in the following files:

  1. packages\drivers\odsp-driver\src\test\odspCreateContainer.spec.ts
  2. packages\drivers\odsp-driver\src\test\odspDriverResolverTest.spec.ts
  3. packages\tools\webpack-fluid-loader\src\odspUrlResolver.ts
@ghost ghost added the triage label Nov 10, 2021
@sonalivdeshpande sonalivdeshpande changed the title Replace createCreateNewRequest with createOdspCreateContainerRequest Replace createCreateNewRequest with createOdspCreateContainerRequest Nov 10, 2021
@sonalivdeshpande sonalivdeshpande self-assigned this Nov 10, 2021
@ChumpChief
Copy link
Contributor

In order to remove from webpack-fluid-loader, you might need to update multiResolver.ts to use the real ODSP url resolver (from odsp-driver). It might be easiest to do this as two separate PRs, one that only touches the odsp-driver files, and a second that modernizes multiResolver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants