Replace createCreateNewRequest with createOdspCreateContainerRequest #8233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
vladsud and
jatgarg
and removed request for
a team
github-actions
bot
added
area: driver
sonalivdeshpande
requested review from
sumedhb1995 and
a team
and removed request for
tanviraumi,
znewton,
vladsud and
jatgarg
github-actions
bot
requested review from
anthony-murphy
and removed request for
a team
github-actions
bot
requested review from
vladsud,
jatgarg,
tanviraumi and
znewton
and removed request for
a team
github-actions
bot
requested review from
GaryWilber,
hedasilv and
pradeepvairamani
⯆ @fluid-example/bundle-size-tests: -219 Bytes
Baseline commit: 99a0dd2 |
github-actions
bot
removed
the
area: server
heliocliu
reviewed
Nov 12, 2021
ChumpChief
reviewed
Nov 17, 2021
server/routerlicious/packages/routerlicious-base/src/alfred/runnerFactory.ts
Outdated
Show resolved
Hide resolved
github-actions
bot
removed
the
area: server
heliocliu
approved these changes
Nov 18, 2021
BREAKING.md
Outdated
|
|
||
| ### `chaincodePackage` removed from `Container` | ||
| The `chaincodePackage` property on `Container` was deprecated in 0.28, and has now been removed. Two new APIs have been added to replace its functionality, `getSpecifiedCodeDetails()` and `getLoadedCodeDetails()`. Use `getSpecifiedCodeDetails()` to get the code details currently specified for the `Container`, or `getLoadedCodeDetails()` to get the code details that were used to load the `Container`. | ||
|
|
||
| ### `OdspDocumentInfo` type replaced with `OdspFluidDataStoreLocator` interface | ||
| The `OdspDocumentInfo` type is removed from `odsp-driver` package. It is removed from `packages\drivers\odsp-driver\src\contractsPublic.ts` and replaced with `OdspFluidDataStoreLocator` interface as parameter in `OdspDriverUrlResolverForShareLink.createDocumentUrl()`. If there are any instances of `OdspDocumentInfo` type used, it can be simply replaced with `OdspFluidDataStoreLocator` interface. | ||
|
|
||
| ### Replace `createCreateNewRequest` function with `createOdspCreateContainerRequest` function | ||
| The `createCreateNewRequest` function is removed from `odspDriverUrlResolver.ts` and `odspDriverUrlResolverForShareLink.ts` files under the `odsp-driver` package. `createCreateNewRequest` function is replaced with `createOdspCreateContainerRequest` function in `odspCreateContainer.spec.ts` and `odspDriverResolverTest.spec.ts`. The update is also made in `webpack-fluid-loader` package. If any instances of `createCreateNewRequest` function are used, replace them with `createOdspCreateContainerRequest` function by importing it from `@fluidframework/odsp-driver` package. |
There was a problem hiding this comment.
no need to call out what you changed in the test files. these notes should only cover changes to the public api/usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to remove on of the deprecated function
createCreateNewRequestfromodsp-driverpackage and replace it withcreateOdspCreateContainerRequestfunction.Fixes #8223