Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Core-Interfaces readme section on FluidObject #8253

Closed
Tracked by #7613
anthony-murphy opened this issue Nov 15, 2021 · 0 comments
Closed
Tracked by #7613

Add Core-Interfaces readme section on FluidObject #8253

anthony-murphy opened this issue Nov 15, 2021 · 0 comments
Assignees
Milestone

Comments

@anthony-murphy
Copy link
Contributor

Really glad you found a good a way to accommodate proper delegation, yay! Can you update this doc comment to cover at least briefly about using Partial<IProvideFoo> if you want to do proper delegation? And I'm with Vlad - mentioning IProvideFoo.IFoo.IFoo doesn't necessarily bring clarity. That is indeed how the type magic works (it finds any prop that also exists on the prop's type), but not how this stuff is ever used.

Originally posted by @markfields in #8087 (comment)

@ghost ghost added the triage label Nov 15, 2021
@anthony-murphy anthony-murphy added this to the March 2022 milestone Feb 3, 2022
@ghost ghost removed the triage label Feb 3, 2022
@anthony-murphy anthony-murphy self-assigned this Mar 1, 2022
@anthony-murphy anthony-murphy modified the milestones: March 2022, April 2022 Mar 1, 2022
@anthony-murphy anthony-murphy modified the milestones: April 2022, May 2022 Apr 4, 2022
anthony-murphy added a commit that referenced this issue Apr 11, 2022
Update IFluidObject documentation to references to FluidObject, and fix some doc bugs.

related #8253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant