Add connectionState to IFluidContainer
#9396
Assignees
Milestone
Comments
7 tasks
ghost
added
the
Repository owner
moved this from In Review
to Done
in Fluid DevX
Apr 7, 2022
scottn12
added a commit
that referenced
this issue
Apr 7, 2022
…ume()`, and `connected` (#9439) For context on the reasoning behind these changes see: #8745 This PR adds `connect()` and `disconnect()` to `Container` and `IContainer`. These functions will combine to replace the functionality of `Container.setAutoReconnect()` (which is deprecated here). Furthermore, `connect()` is essentially a rename of `Container.resume()`, hence `resume()` has been deprecated as well. In addition, `IContainer.connected` has been deprecated in favor of `IContainer.connectionState`. To make `IFluidContainer` consistent with these changes, `connectionState` has been added to `IFluidContainer`, and `IFluidContainer.connected` has been deprecated as well. Follow up items: 1. Add `connect()` and `disconnect()` to `IFluidContainer` and `IContainer` 2. Add tests for the new functionality 3. Update documentation referencing deprecated APIs 4. Explore behavior if `disconnect()` is called while the container is attempting to connect Closes #9396, #9167, #9744
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To make
IFluidContainerandIContainerconsistent,connectionStatewill be added toIFluidContainer. This will be preferred overIFluidContainer.connectedwhich will be deprecated in #9167.The text was updated successfully, but these errors were encountered: