Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 9905 - Investigate negative numbers on Summary's timeSinceLastAttempt field #10033

Merged
merged 3 commits into from
Apr 26, 2022

Conversation

NicholasCouri
Copy link
Contributor

Fix #9905 - Do not user server timestamp during the first summary.

@NicholasCouri NicholasCouri requested a review from a team as a code owner April 25, 2022 19:58
@github-actions github-actions bot added area: runtime Runtime related issues base: main PRs targeted against main branch labels Apr 25, 2022
@NicholasCouri NicholasCouri changed the title Fix for 9905 Fix for 9905 - Investigate negative numbers on Summary's timeSinceLastAttempt field Apr 25, 2022
@agarwal-navin
Copy link
Contributor

I think it may be worth adding a comment somewhere that the timeSinceLastAttempt and timeSinceLastSummary for the first summary are basically time since the summarizer loaded. Maybe the place where we initialize these when attempting a summary?

@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Apr 25, 2022

@fluid-example/bundle-size-tests: +95 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 398.71 KB 398.73 KB +19 Bytes
containerRuntime.js 220.31 KB 220.33 KB +19 Bytes
loader.js 160.49 KB 160.49 KB No change
map.js 235.41 KB 235.42 KB +19 Bytes
matrix.js 323.31 KB 323.33 KB +19 Bytes
odspDriver.js 182.42 KB 182.42 KB No change
odspPrefetchSnapshot.js 77.23 KB 77.23 KB No change
sharedString.js 343.89 KB 343.9 KB +19 Bytes
Total Size 1.93 MB 1.93 MB +95 Bytes

Baseline commit: 7574512

Generated by 🚫 dangerJS against 0d5b405

@NicholasCouri NicholasCouri added this to the April 2022 milestone Apr 26, 2022
@NicholasCouri NicholasCouri merged commit 160894b into microsoft:main Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: runtime Runtime related issues base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate negative numbers on Summary's timeSinceLastAttempt field.
3 participants