bug fixes in creation driver #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladsud
reviewed
Feb 4, 2020
packages/drivers/create-new-driver/src/creationDocumentServiceFactory.ts
Outdated
Show resolved
Hide resolved
vladsud
reviewed
Feb 4, 2020
| return new CreationDocumentService("createNewFileDoc", "createNewFileDocTenant"); | ||
| return new CreationDocumentService( | ||
| (url as IFluidResolvedUrl).url, | ||
| "createNewFileDoc", |
There was a problem hiding this comment.
createNewFileDoc [](start = 13, length = 16)
Where docId is used currently?
At a minimum, it is used in telemetry, and it would be great to have unique ID per doc, such that in Teams / drafts scenario we keep using same ID across multiple sessions.
I.e. it needs to come from uri / host and it needs to be unique (when starting new file; ID will be reused when they reopen draft)
There was a problem hiding this comment.
This docid is currently used in mapping the server instance with the docid.
curtisman
pushed a commit
that referenced
this pull request
Feb 13, 2020
* bug fixes in creation driver * PR * PR * PR
curtisman
pushed a commit
that referenced
this pull request
Feb 14, 2020
* bug fixes in creation driver * PR * PR * PR
This was referenced Nov 4, 2022
This was referenced Nov 4, 2022
This was referenced Nov 5, 2022
This was referenced Nov 5, 2022
This was referenced Nov 5, 2022
This was referenced Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.