-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable message batching for Azure customers #11568
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Let's get a few more eyes on this before it goes in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is the direction we want to go here. We have work tracking for this problem at https://dev.azure.com/fluidframework/internal/_workitems/edit/465
A better solution would be explicitly setting the value of |
Scoped down the fix to a single line change in |
This commit is queued for merging with the |
* Add e2e test to demo use of flush mode * override flush mode for azure clients * disable new test for local driver * PR feedback
* Add e2e test to demo use of flush mode * override flush mode for azure clients * disable new test for local driver * PR feedback
The problem
The problem reported by a customer via IcM. Attempting to sync a large data set consisting of batched multiple messages (less than 768kb each) will hit Socket.io buffer max size and the connection will close. The reason is the delta manager flushes batched messages periodically without enforcing the max op size. The max op size is only honored by the container runtime per each message submitted as imposed by the initial design.
The solution
Disable the message batching by setting
flushMode
toIntermediate
for Azure customers. The workaround should be reconsidered when the original batching problem is resolved.