error in DeltaManager.connect() instead of assert #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladsud
reviewed
Feb 11, 2020
| @@ -404,6 +404,9 @@ export class Container extends EventEmitterWithErrorHandling implements IContain | |||
| } | |||
|
|
|||
| public resume() { | |||
| if (this.closed) { | |||
| return; | |||
| } | |||
There was a problem hiding this comment.
I'd prefer to throw more descriptive error in DeltaManager.connect() and push it to apps to not call resume after then closed container.
Basically no silent failures - it's a bug in their workflow.
wes-carlson
changed the title
This was referenced Sep 15, 2021
This was referenced Nov 4, 2022
This was referenced Nov 5, 2022
This was referenced Nov 5, 2022
This was referenced Nov 5, 2022
jason-ha
pushed a commit
that referenced
this pull request
Jan 23, 2025
#1229) Bumps [globals](https://github.com/sindresorhus/globals) from 15.11.0 to 15.12.0. - [Release notes](https://github.com/sindresorhus/globals/releases) - [Commits](sindresorhus/globals@v15.11.0...v15.12.0) --- updated-dependencies: - dependency-name: globals dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
resume()on a closed container seems to account for a significant proportion of assertion failures reported. If a container is closed whenresume()is called, it callsconnectToDeltaStream()which in turn callsdeltaManager.connect(), causing an immediate assertion failure since the deltaManager is closed when the container is closed.