Update Vltava to new npm run start modes #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heliocliu
reviewed
Feb 12, 2020
| @@ -22,7 +22,9 @@ | |||
| "lint:fix": "npm run eslint:fix", | |||
| "start": "webpack-dev-server --config webpack.config.js --package package.json", | |||
| "start:docker": "webpack-dev-server --config webpack.config.js --package package.json --env.mode docker", | |||
| "start:live": "webpack-dev-server --config webpack.config.js --package package.json --env.mode live", | |||
| "start:r11s": "webpack-dev-server --config webpack.config.js --package package.json --env.mode r11s", | |||
| "start:spo-df": "webpack-dev-server --config webpack.config.js --package package.json --env.mode spo-df", | |||
There was a problem hiding this comment.
spo-df": [](start = 11, length = 8)
maybe too late but "spo" should come before "spo-df" alphabetically
This was referenced Sep 15, 2021
This was referenced Nov 4, 2022
This was referenced Nov 4, 2022
This was referenced Nov 5, 2022
This was referenced Nov 5, 2022
This was referenced Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timing that these were initially merged caused Vltava to be missed. Add spo and spo-df modes to npm run start commands, and change live to r11s.