-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vltava - DateEvent Data-Binding With MatchMaker #1236
Closed
skylerjokiel
wants to merge
30
commits into
microsoft:master
from
skylerjokiel:aqueduct-container-modular
Closed
Vltava - DateEvent Data-Binding With MatchMaker #1236
skylerjokiel
wants to merge
30
commits into
microsoft:master
from
skylerjokiel:aqueduct-container-modular
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto aqueduct-container-modular
skylerjokiel
added
area: examples
Changes that focus on our examples
area: framework
Framework is a tag for issues involving the developer framework. Eg Aqueduct
labels
Feb 12, 2020
skylerjokiel
requested review from
tylerbutler,
anthony-murphy,
ChumpChief,
sumedhb1995,
curtisman and
vladsud
February 12, 2020 06:53
This was referenced Nov 5, 2022
This was referenced Nov 5, 2022
This was referenced Nov 5, 2022
jason-ha
pushed a commit
that referenced
this pull request
Jan 23, 2025
Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.6.3 to 5.7.2. - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml) - [Commits](microsoft/TypeScript@v5.6.3...v5.7.2) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: examples
Changes that focus on our examples
area: framework
Framework is a tag for issues involving the developer framework. Eg Aqueduct
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the matchmaker to bind data between producers and consumers of date event data.
There are two new components. The Calendar consumes event data and the EventItem produces event data.
They register with the matchmaker which means that the Calendar will consume all events on the page. The Calendar holds a Handle to the EventItem as a way to resolve it without the matchmaker in the future.
Problems
The matchmaker isn't fully suited to this scenario. The handles help but there's still the problem that once loaded the calendar or new event will not both be loaded on the page at the same time. This could cause the calendar to miss events.
Live Code
https://www.wu2-ppe.prague.office-int.com/waterpark/complete-profit?chaincode=@fluid-example/vltava@0.14.0-skjokiel-1