Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial basic support for OneDrive Consumer in odsp driver #1238

Merged
merged 9 commits into from
Feb 18, 2020

Conversation

viz-msft
Copy link
Contributor

  • Driver now understands URLs from OneDrive Consumer (ODC) in both Vroom format (similar to SPO) and OData format (which ODC prefers to use)
  • Tagged some areas that assume SPO that will need to be updated for ODC

There will be a ramp that needs to be opted into for ODC to expose the Fluid API endpoints; details via Marcello soon. PushChannel also has some changes pending server-side to support ODC.

@viz-msft viz-msft requested a review from GaryWilber February 12, 2020 21:14
@GaryWilber GaryWilber requested a review from vladsud February 12, 2020 21:33
@vladsud
Copy link
Contributor

vladsud commented Feb 12, 2020

Can you please figure out where to add telemetry such that we can differentiate those two end points?
Single event somewhere will do it, but hard to use.
A property available on most events coming from driver is easier to use, but harder to add

@vladsud
Copy link
Contributor

vladsud commented Feb 12, 2020

I think you want to move this PR into release/0.13 branch, to speed up bringing it to Bohemia
We have automated process to bring commits from there to master.

Copy link
Contributor

@vladsud vladsud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@viz-msft viz-msft changed the base branch from master to release/0.13 February 13, 2020 18:49
@viz-msft
Copy link
Contributor Author

viz-msft commented Feb 13, 2020

Repointing to 0.13, will need to do some rebasing. I'll add in some telemetry too and refactor a bit more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants