More informative error messages for when we can't instantiate components #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmincatrinescu
approved these changes
Feb 13, 2020
leeviana
approved these changes
Feb 13, 2020
| return this.componentRuntimeDeferred.promise; | ||
| } | ||
| factory = entry.IComponentFactory; | ||
| registry = entry.IComponentRegistry; | ||
| } | ||
|
|
||
| if (factory === undefined) { | ||
| throw new Error(`Can't find factory for ${lastPkg} package`); |
There was a problem hiding this comment.
we should follow the above pattern here:
this.componentRuntimeDeferred.reject(`Registry does not contain an entry for the package ${pkg}`);
return this.componentRuntimeDeferred.promise;
otherwise there will be a dangling deferred promise
…into BetterErrorMsgsRegistry
…into BetterErrorMsgsRegistry # Conflicts: # packages/runtime/container-runtime/src/componentContext.ts
…into BetterErrorMsgsRegistry
This was referenced Sep 15, 2021
This was referenced Nov 4, 2022
This was referenced Nov 5, 2022
This was referenced Nov 5, 2022
This was referenced Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.