Upgrade sort-package-json and enforce it in lint #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wes-carlson
approved these changes
Feb 22, 2020
tools/fluid-build/src/npmPackage.ts
Outdated
| @@ -7,7 +7,7 @@ import { queue } from "async"; | |||
| import * as chalk from "chalk"; | |||
| import * as fs from "fs"; | |||
| import * as path from "path"; | |||
| import { sortPackageJson } from "sort-package-json"; | |||
| import sortPackageJson from "sort-package-json"; | |||
There was a problem hiding this comment.
What's the reason for this change?
There was a problem hiding this comment.
I think it's because the typings changed in the new version, but I don't quite understand how that all works and all the import syntaxes. Without this change tsc -b failed.
@curtisman Can you explain the difference between the two imports above?
This was referenced Sep 15, 2021
This was referenced Nov 5, 2022
This was referenced Nov 5, 2022
This was referenced Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This initial iteration should fail the CI lint run. Once confirmed, a second iteration will correct the build break.All PR builds pass.This PR upgrades the version of sort-package-json to the latest, but it remains pinned. New npm tasks are added to support linting and lint auto-fixing.
Relevant NPM tasks
sort:lint- checks that all package.json files are sorted; this task is designed to be run locally given the current repo layoutsort:lint:min- minimal linting for running in CI; called in the primarylinttasksort:lint:fix- auto-fixes sorting errors; called in the primarylint:fixtask