Support Multiple Drivers In IFrames #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into iframe-multiple-drivers
…into iframe-multiple-drivers
vladsud
reviewed
Mar 4, 2020
| * Api that creates the protocol to factory map. | ||
| * @param documentServiceFactories - A single factory or array of document factories. | ||
| */ | ||
| export function createProtocolToFactoryMapping( |
There was a problem hiding this comment.
createProtocolToFactoryMapping [](start = 16, length = 30)
Given that these two functions are not really used as stand-alone, I'd move them as members into DocumentServiceFactoryProtocolMatcher class
There was a problem hiding this comment.
i've removed the exports, but leaving them out of the class for now, as i'm predicting some changes in this area with container create, url creation, etc.
…into iframe-multiple-drivers
…murphy/FluidFramework into iframe-multiple-drivers
This was referenced Aug 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1326